Skip to content

requesting to add myself as a reviewer/approver#2148

Merged
istio-testing merged 1 commit intomasterfrom
kyessenov-patch-1
Mar 11, 2019
Merged

requesting to add myself as a reviewer/approver#2148
istio-testing merged 1 commit intomasterfrom
kyessenov-patch-1

Conversation

@kyessenov
Copy link
Contributor

I have 39 commits in this repo.

I have 39 commits in this repo.
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 7, 2019
@istio-testing istio-testing requested review from linsun and utka March 7, 2019 23:55
@utka
Copy link
Contributor

utka commented Mar 8, 2019

Is there official rule who can be added to OWNERS file?

@linsun
Copy link
Member

linsun commented Mar 8, 2019

I think we have a rule for WG leads to promote folks as owners. However, for proxy repo, should it belong to networking WG?

@mandarjog mandarjog removed request for linsun and utka March 8, 2019 21:22
@kyessenov
Copy link
Contributor Author

Majority of additions in proxy are for policy, telemetry, and security functions. So I don't think this is a purely networking component.

@mandarjog mandarjog requested a review from rshriram March 8, 2019 21:23
@mandarjog
Copy link
Contributor

The ownership is split across P&T and Networking.
@rshriram @lizan please approve.

The owners file does need cleaning in proxy.

@lizan
Copy link
Contributor

lizan commented Mar 8, 2019

/lgtm
/approve

@rshriram
Copy link
Member

/lgtm

@kyessenov kyessenov added the lgtm label Mar 11, 2019
@istio-testing istio-testing merged commit ef62615 into master Mar 11, 2019
istio-testing pushed a commit that referenced this pull request May 1, 2019
* Forwarded attributes override statically configured Local Attributes (#2097)

* WIP

* add local and override tests

* revert attributes_builder

* white list forward attributes

* add tests with whitelist

* fix builder test for white listed attributes

* ignore istio.mixer in report (#2098)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* whitelist kSourceNamespace attribute (#2100)

* Update software in the build image used by CircleCI. (#2110)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* Add flag indicating current semantics of report batch (#2111)

* Add flag indicating current semantics of report batch

* Fix Unit Test

* Update Envoy SHA to latest with deterministic hash (master). (#2108)

* Update Envoy SHA to latest with deterministic hash (master).

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* review: use lld linker for clang-asan and clang-tsan.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* review: export PATH.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* Update Envoy SHA to latest with deterministic hash (release-1.1). (#2109)

* Update Envoy SHA to latest with deterministic hash (release-1.1).

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* review: use lld linker for clang-asan and clang-tsan.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* review: export PATH.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* remove unused bytestring include from sni_verifier for openssl (#2112)

* Added client/server load test framework to find mixer faults. (#2105)

This is a load generator client + origin server I created to test the Mixer filter under various fault conditions using Envoy's client and server stacks. This work falls under [istio/istio#8224](istio/istio#8224)

@PiotrSikora @jplevyak would love your feedback because it could be used for the wasm work and especially because this is the first >=C++11 code I've written

See test/integration/int_client_server_test.cc if you want to start with an example for context.

Another example that uses this framework to sandwich Envoy+Mixer filter between the load generator and multiple origin servers simulating Mixer servers can be found in [istio/istio#8224](istio/istio#8224)

* Warn user of using mTLS PERMISSIVE mode and suggest to upgrade to STRICT mode (#2114)

* Warn user of using mTLS PERMISSIVE mode and suggest to upgrade to STRICT mode.

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* fix format

* check in constructor

* Update to latest istio/api on release-1.1 branch (#2115)

* Update to latest istio/api on release-1.1 branch

* Update istio/api to latest release-1.1

* Added simple logging abstraction so mixer client logs can be relayed to envoy logs. (#2116)

* Added simple logging abstraction so mixer client logs can be relayed to envoy logs when running inside envoy, stderr when running standalone.

* Log threshold guards that prevent needless serialization of logging arguments are now embedded in the log macros.

* Format

* Added do/while guards around logging statements.

* Coalesce all memory for checks and reports into shared pointers (#2117)

* Coalesce all memory for policy check requests and telemetry reports into shared pointers that live as long as a request's mixer filter instance.

* A few small fixups for the code review.

* Address some minor nits from code review.

* Additional counters for mixer policy check (#2118)

* Coalesce all memory for policy check requests and telemetry reports into shared pointers that live as long as a request's mixer filter instance.

* A few small fixups for the code review.

* Added finer-grained counters to mixer policy check

* Add retries to policy checks on failed transport error (#2113)

* Add configurable retry to policy/quota checks that failed due to transport error.

* Added assertions on mixer filter stats to mixer fault test.

* Reformat

* Fix inaccurate comment.
`

* Fix asan warning (thanks @silentdai!) and exclude mixer_fault_test from
the asan and tsan sanitizers since it always times out.

* Fix bad prefix check

* Pull in latest istio/api from release-1.1 branch (#2120)

* Add Joshua into proxy OWNER (#2121)

* log authn permissive mode only when config is received (#2125)

* log authn permissive mode only when config is received

Signed-off-by: Yangmin Zhu <ymzhu@google.com>

* fix format

* fix build

* clang-6/gcc: compiler barking fix (#2123)

* compiler barking

Signed-off-by: Kuat Yessenov <kuat@google.com>

* piotrs fix

Signed-off-by: Kuat Yessenov <kuat@google.com>

* Add additional telemetry report counters (#2128)

* Added counters to track telemetry report result.

* reformat

* replace tabs with spaces

* Replace more tab with spaces.

* New api sha for proxy (#2130)

* API sha just changed, chanign it again for proxy (#2131)

* Remove myself from owners add utka instead (#2129)

* implement upstream secure bit (#2133)

Signed-off-by: Kuat Yessenov <kuat@google.com>

* Deflake macos MixerFaultTest by broadening assertion ranges. (#2126)

* Deflake macos MixerFaultTest by broadening assertion ranges.

Fix flake in macos tests that was introduced by #2113

* Cleanup a few readability issues and add an assertion.

* More redability changes.

* API sha for proxy (#2136)

* Revert "implement upstream secure bit (#2133)" (#2135)

This reverts commit d857bdd.

* Add the support of bypassing JWT authn for CORS requests (#2139)

* Add the support of bypassing JWT authn for CORS requests

* Bail out earlier for CORS preflight requests

* Use OPTIONS constant value from Envoy

* Remove changing to lowercase

* Add more checks for CORS preflight requests (#2140)

* Rc3. new API sha for proxy. (#2146)

* API sha for proxy

* API sha for proxy

* update envoy with latest build fixes (#2147)

* update envoy with latest build fixes

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* update protobuf to match envoy

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* timeSystem -> timeSource

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* requesting to add myself as a reviewer/approver (#2148)

I have 39 commits in this repo.

* update envoy to pick up TLS logging for HTTP upstream (#2149)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* Building 1.1rc4 (#2150)

* fix build

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* fix format

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* fix status match

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* Fixes environment-dependent failures in MixerFaultTest (#2156)

* Removed explicit log-level setting from tests, as it was interfering with cli '-l' option (#2155)

* Update_Dependencies (#2178)

* Update envoy sha and fix bulid break (#2179)

* update envoy sha

* fix build

* Remove bazel shutdown from make deb

* Ignore error code returned from bazel shutdown
@kyessenov kyessenov deleted the kyessenov-patch-1 branch December 15, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants